03-07-2019, 11:24 PM
Sorry I can't see any of the images, they appeared to be blocked from the host, they just display an icon.
Thanks for your thoughts, everything you said makes sense.
So I've been going through the maintenance code and have found some issues, a little disappointed as I spent so much time testing everything but there was some definite problems. I have figured out why you experienced what you did and this is why.
First issue was heaters/chillers were disabled for 255 minutes after maintenance starts no matter on duration set. Because I added custom rules to only run during or after maintenance I had to put a limit on when maintenance actually finished so I went with 255 minutes. This means if you turned any outlets/DC accessories on/off using the maintenance settings page they would resume once set duration expires but the custom rules based on maintenance would continue to be monitored for the remaining 255 minutes. As an example the custom rule can be set to run 2 hours after maintenance is finished even if maintenance only lasts 30 minutes. This could be good for possible dosing or whatever.
This was supposed to be setup so once the duration set was reached the heaters would be enabled again but that was only happening on the display because it doesn't monitor custom rules. That's why when you restarted just the display the heater appeared on but the controller still wouldn't let it come on. For timing reasons during startup I had to add a one time function that only runs when display starts which sets the icons to the correct state for only the heaters and chillers, that's why you had that discrepancy, I'm going to change that so like everything else the controller tells the display what to lite up.
I've been busy cleaning up the issues I found and will take your advice. I should have an update in a few hours.
Thanks for your thoughts, everything you said makes sense.
So I've been going through the maintenance code and have found some issues, a little disappointed as I spent so much time testing everything but there was some definite problems. I have figured out why you experienced what you did and this is why.
First issue was heaters/chillers were disabled for 255 minutes after maintenance starts no matter on duration set. Because I added custom rules to only run during or after maintenance I had to put a limit on when maintenance actually finished so I went with 255 minutes. This means if you turned any outlets/DC accessories on/off using the maintenance settings page they would resume once set duration expires but the custom rules based on maintenance would continue to be monitored for the remaining 255 minutes. As an example the custom rule can be set to run 2 hours after maintenance is finished even if maintenance only lasts 30 minutes. This could be good for possible dosing or whatever.
This was supposed to be setup so once the duration set was reached the heaters would be enabled again but that was only happening on the display because it doesn't monitor custom rules. That's why when you restarted just the display the heater appeared on but the controller still wouldn't let it come on. For timing reasons during startup I had to add a one time function that only runs when display starts which sets the icons to the correct state for only the heaters and chillers, that's why you had that discrepancy, I'm going to change that so like everything else the controller tells the display what to lite up.
I've been busy cleaning up the issues I found and will take your advice. I should have an update in a few hours.
