03-18-2022, 05:01 AM
(03-18-2022, 04:40 AM)SyberSects Wrote:(03-18-2022, 03:11 AM)gandalf Wrote: great newsjust curious. what bug? i've been using the dosing feature for about 2 months with.. as far as i can tell.. no issues?
did you add the bug fixes i've provided to you or should i port them to V6.4? as i'm using the dosing feature on a real tank, without the fixes the dosing won't work as expected
If you need to dose high volumes with low speed pumps (in example the Kamoer KFS), the milliseconds needed as doseRunTime is a number higher than the max allowed value in the robo-tank server, it will overflow being used as a negative value, thus the pump will always run because the server isn't unable to handle the running time and stop the pump.
Also it was impossible to set more than 2000ms as ms/ml and in my case I have 3750ms and so on. Some little bug (except the previous one that is critial) making the usage of dosing feature not perfect with some high-precision pumps
I'm dosing 17.70ml daily of a Triton mix (decimal values as dose amount was another fix made by me) at 3750ms/ml, thus 66.375seconds.
With standard v6.3 or lower, it breaks as doseRunTime is a short integer, so 2^15 = 32767. You can't dose anything more than 32seconds or the pump will spin forever.
My fix increase this to unsigned int, so 4294967295 milliseconds and I saw that is merged in v6.4